Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIBULKED-588 Displaying errors and warnings #678

Merged
merged 12 commits into from
Jan 24, 2025
Merged

UIBULKED-588 Displaying errors and warnings #678

merged 12 commits into from
Jan 24, 2025

Conversation

vashjs
Copy link
Contributor

@vashjs vashjs commented Jan 23, 2025 •
edited
Loading

In scope of this PR logic related to show warnings in errors table was implemented.

Changes:

  • show error type in table column (Warning or Error)
  • show correct warning count
  • add filtration to useQuery based on error type, when user clicks "Show warnings" checkbox
  • disable "Show warnings" checkbox if there are no warnings
  • update tests

image

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

Jest Unit Test Statistics

    1 files  ±0    53 suites  +1   3m 19s ⏱️ +8s
335 tests +4  335 ✔️ +4  0 💤 ±0  0 ❌ ±0 
342 runs  +4  342 ✔️ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 77264b2. ± Comparison against base commit 773b8dc.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 77264b2. ± Comparison against base commit 773b8dc.

♻️ This comment has been updated with latest results.

@vashjs vashjs closed this Jan 24, 2025
@vashjs vashjs reopened this Jan 24, 2025
@vashjs vashjs marked this pull request as ready for review January 24, 2025 10:45
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@vashjs vashjs merged commit 06cf887 into master Jan 24, 2025
6 checks passed
@vashjs vashjs deleted the UIBULKED-588 branch January 24, 2025 15:02
@vashjs vashjs mentioned this pull request Jan 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UladzislauKutarkin UladzislauKutarkin UladzislauKutarkin approved these changes

@artem-blazhko artem-blazhko artem-blazhko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vashjs @artem-blazhko @UladzislauKutarkin